Repository navigation
[i2c, dv] Removed the inactive thread - #31253
Merged
Merged
Conversation
KinzaQamar
requested review from
hcallahan-lowrisc and
rswarbrick
and removed request for
a team
September 7, 2026 13:50
KinzaQamar
force-pushed
the
i2c_seq_stop
branch
from
September 7, 2026 14:21
54f68b5 to
c9f94b3
Compare
rswarbrick
reviewed
Sep 15, 2026
rswarbrick
left a comment
rswarbrick
left a comment
Contributor
There was a problem hiding this comment.
Given that the task isn't used anywhere in the repository, I think we should probably drop it and the associated variable too?
We'll get this wait(stop) thread activated by calling seq_stop() in i2c_base_seq which is not been done anywhere for I2C DV. Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_seq_stop
branch
from
September 18, 2026 10:22
c9f94b3 to
d818616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll get this wait(stop) thread activated by calling seq_stop() in i2c_base_seq which is not been done
anywhere for I2C DV.