Repository navigation
Conversation
mawilk90
added
improvement
mawilk90
requested review from
ezilber-akamai,
jcamelon,
jriddle-linode and
psnoch-akamai
and removed request for
a team and
jcamelon
October 21, 2026 11:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused naming change matches the refreshed fixture, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Reduces domain-clone smoke test name collisions by deriving the clone name from the source domain.
Changes:
- Replaces the fixed clone name with a source-derived name.
- Registers teardown with
t.Cleanup. - Refreshes the recorded integration fixture.
| File | Description |
|---|---|
| test/integration/fixtures/TestDomain_Clone.yaml | Updates recorded names, resource IDs, and response metadata. |
| test/integration/domains_test.go | Derives clone names and updates cleanup registration. |
Review effort: Balanced
ezilber-akamai
approved these changes
Oct 21, 2026
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Test passes locally!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added logic for generating names for a cloned domain to avoid issues arising from the existence of identical domain names.
✔️ How to Test
make fixtures TEST_ARGS="-run TestDomain_Clone_smoke"ormake test-int TEST_ARGS="-run TestDomain_Clone_smoke"