run-vmtest: make kernel_splat detection optional - #235
Open
theihor wants to merge 3 commits into
Open
Conversation
theihor
commented
Aug 17, 2026
theihor
commented
Contributor
- Don't do kernel splat check when configs aren't set up
- If a kernel splat is detected, dump it in error summary for visibility
- While we are here, remove -x from the scripts (it was used for debugging, shouldn't be on by default)
Existing action users do not necessarily carry kernel splat allowlist and denylist files. Treating a missing denylist as a detector failure therefore breaks those users when the v4 tag advances. Skip the detector when neither configured list path exists, while continuing to fail partial or invalid configurations once either file exists. With file presence as the feature gate, remove the test_progs-only check so configured test_maps and test_verifier runs are scanned too. Add regression coverage for configured paths with no list files. Assisted-by: Codex:GPT-5 Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
The detector runs inside the outer vmtest log group, so its matched context remains collapsed even though it emits a GitHub error. Write a short diagnostic excerpt next to exitstatus and print it from the host after the vmtest group closes. Use its first line for the error annotation so the failure is visible immediately, while retaining dmesg.txt as the full-log artifact. Build the excerpt from the already allowlist-filtered hits. The previous second grep used the raw denylist again, reintroducing allowed matches and potentially printing thousands of unrelated lines. Add coverage for saved excerpts and a log containing both allowed and unallowed splats. Assisted-by: Codex:GPT-5 Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Global xtrace in the run-vmtest entry points logs every variable assignment and helper invocation. Recent test jobs gained 317 to 340 trace lines each, amounting to roughly 8,000 lines across a full workflow. The scripts already print the useful commands, selected list files, and final results. Drop global xtrace from run.sh, prepare-bpf-selftests.sh, and run-bpf-selftests.sh while retaining errexit, nounset, and pipefail. The focused xtrace around veristat commands remains. Assisted-by: Codex:GPT-5 Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.