feat(webhooks)!: add nullable Basic Auth fields and safe read flags - #11
Merged
Merged
Conversation
bjarn
changed the title
Bjornftw
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add typed webhook Basic Auth credentials and required has_basic_auth read flags. Preserve omitted, set and explicit-null requests, including empty passwords. Redact credential Debug output. Bearer API authentication is unchanged.
Source
Fresh strict OpenAPI export from main bfabb708ead47ee31922a7ae772e3d6376ac2ea4 after backend PR https://github.com/lettermint/lettermint/pull/2578. Splitter: 7 tests pass, no skips. Both split outputs match the docs. No OpenAPI files are included.
Team SHA-256: e385c5f9b330633e943729ecb0e1b93fca96e84fecb2f111b3af8f0bafa0cc75
Sending SHA-256: c2aafb6d48a2572e688224629076748322f9c257394f18fe8879efb3f05059cb
Verification
28 integration tests and one compile-fail old-caller test pass. cargo fmt and clippy pass. Existing CursorPaginator, cancel return type, scheduling and signed webhook helpers remain.
Intentional source compatibility change
Old complete struct literals need the new basic_auth or has_basic_auth fields. The compile-fail test proves this break. Add basic_auth: None or use ..Default::default(). Set credentials with Some(Some(WebhookBasicAuthData { username, password })); use Some(None) to clear them, or None to retain them on update. Binary compatibility is not promised for Rust crate interfaces.
No merge, release or deployment was performed.