fix(types): expose inbound route domains and correct transport lint - #10
Merged
Merged
Conversation
Bjornftw
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Expose optional nullable RouteData.inbound_route_domain. Correct a stale single-send fixture. Limit the async_trait double_must_use lint exception to the transport trait.
Source contract
The combined specification was exported from revision cc20d3a24c8e1fdfc18dc3ced7a49071505dfba4, then split in a temporary workspace with the current docs script. Both outputs match the stored docs bytes. No source specification was changed or copied into this repository.
Team SHA-256: d29092db4b56011987088aadd8b71d2e3fe8a242441b206bfa6cf49d7409c31e.
Local validation
24 integration tests; cargo fmt; Clippy with denied warnings on Rust 1.98.0.
Compatibility
Keep CursorPaginator and the cancellation type alias. PingResponse remains String, as required for pong.
The added public RouteData field can break complete Rust struct literals. Add
inbound_route_domain: None, or use..Default::default()where the caller does not set this field.This PR does not merge or release the SDK.