Repository navigation
perf: optimize literal classification and extend numeric literal support - #15934
Merged
Merged
Conversation
This PR optimizes literal recognition and improves `grind` support for rational and signed fixed-width integer literals. Replace value-extractor calls with direct Boolean checks. Add scientific `Rat` recognition and `Int8`/`Int16`/`Int32`/`Int64` extraction and normalization. Fix interpretation of aliased types and handling of literals in match conditions. Add consistency tests covering wrapping, boundaries, metadata, and metavariables.
Member
Author
|
!bench |
|
Benchmark results for 7b56476 against c9a3ebf are in. No significant results found. @leodemoura
Small changes (7✅, 7🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes literal recognition and improves
grindsupport for rational and signed fixed-width integer literals.Replace value-extractor calls with direct Boolean checks. Add scientific
Ratrecognition andInt8/Int16/Int32/Int64extraction and normalization. Fix interpretation of aliased types and handling of literals in match conditions. Add consistency tests covering wrapping, boundaries, metadata, and metavariables.