You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mroguljic I'm finally getting the chance to look at this. Can you explain briefly the intention of isNewConstr and put a description in the docstring with a new @param line?
My only other question is about the changes to setup.py to change to >=. There are some issues doing this with python 2.7. As you can see from the failing GitHub tests, it's trying to use a version of pandas using f string formatting that doesn't work in python 2.7.
Of course, if CMS has finally released a CMSSW version with python 3+ROOT that works and is now standard, we can ignore that :-)
@lcorcodilos isNewConstr was placed so I can instantiate a Correction object which uses the same main function as some already created Correction, but with different arguments provided to the constructor which usually initializes the file/histogram needed for correction. Example of the usage can be found here: https://github.com/mroguljic/Zbb_SF/blob/v1/templateMaker.py#L165-L166
As far as I'm aware, the isClone flag does not provide this option. If this makes sense, I'll go ahead and document this as you proposed.
Regarding the setup.py. I was not aware this was bundled in the PR and it shouldn't be here. This was me trying to test python3 installation. Indeed, there is now a setup which works with CMSSW_12_X and python3. I'll make a separate PR for this once we resolve the first item.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.