Repository navigation
Conversation
pr3etk
commented
Oct 6, 2026
pr3etk
left a comment
Author
There was a problem hiding this comment.
Review findings\n\nNo correctness, regression, security, test, or maintainability issues found.\n\nReviewed slowapi/middleware.py:166-179: the response-start message is now emitted once while every response-body message continues to be forwarded. Reviewed ests/test_streaming.py:13-55, which covers a three-chunk StreamingResponse and rate-limit headers.\n\nValidation on the PR head:\n- pytest tests/test_streaming.py -q: 1 passed\n- Full suite: 92 passed, 12 pre-existing Starlette compatibility failures at ests/test_starlette_extension.py:178,211,236,257 because the installed Starlette lacks
oute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming Middleware Fix Report
Issue
SlowAPIASGIMiddlewareforwarded the storedhttp.response.startASGI message whenever it received anhttp.response.bodymessage. Streaming responses emit multiple body messages, so the middleware sent the response-start message once per chunk. ASGI servers such as Uvicorn reject repeated response-start messages.Changes
response_startedflag to_ASGIMiddlewareResponder.StreamingResponsewith three chunks.Verification
assert 4 == 1because four response-start messages were emitted.pytest tests/test_streaming.py -qpassed:1 passed.92 passed, 12 failed.AttributeError: 'Starlette' object has no attribute 'route'intests/test_starlette_extension.py.Scope
No unrelated Starlette compatibility failures were changed. The fix is limited to ensuring that an ASGI response-start message is sent exactly once for streaming responses.