fix(mcp): include both source failure reasons in get_airspace error - #6097
Open
tagadearpit wants to merge 4 commits into
Open
fix(mcp): include both source failure reasons in get_airspace error#6097tagadearpit wants to merge 4 commits into
tagadearpit wants to merge 4 commits into
Conversation
When civilian and military upstreams both fail, the thrown error discarded civResult.reason and milResult.reason. Sentry (WORLDMONITOR-WV) therefore could not distinguish timeouts from HTTP errors or auth failures. Surface each side's rejection (TimeoutError/AbortError, HTTP status, or Error message) in the error text so correlated shared-host outages are diagnosable. BillingDenialError is still rethrown ahead of this branch. Fixes koala73#6085 Signed-off-by: tagadearpit
|
@tagadearpit is attempting to deploy a commit to the World Monitor Team on Vercel. A member of the Team first needs to authorize it. |
When civilian and military upstreams both fail, the thrown error discarded civResult.reason and milResult.reason. Sentry (WORLDMONITOR-WV) therefore could not distinguish timeouts from HTTP errors or auth failures. Surface each side's rejection (TimeoutError/AbortError, HTTP status, or Error message) in the error text so correlated shared-host outages are diagnosable. BillingDenialError is still rethrown ahead of this branch. Fixes koala73#6085 Signed-off-by: tagadearpit
Extract a pure summarizer and wire it into get_airspace so Sentry (WORLDMONITOR-WV) can distinguish TimeoutError, HTTP status, and other failures when both civilian and military upstreams fail. Fixes koala73#6085 Signed-off-by: tagadearpit
Signed-off-by: tagadearpit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When civilian and military upstreams both fail, the thrown error discarded civResult.reason and milResult.reason. Sentry (WORLDMONITOR-WV) therefore could not distinguish timeouts from HTTP errors or auth failures.
Surface each side's rejection (TimeoutError/AbortError, HTTP status, or Error message) in the error text so correlated shared-host outages are diagnosable. BillingDenialError is still rethrown ahead of this branch.
Fixes #6085
Signed-off-by: tagadearpit
Summary
Type of change
Affected areas
/api/*)Checklist
api/rss-proxy.jsallowlist (if adding feeds)npm run typecheck)Documentation Alignment Checklist
Screenshots