Skip to content

fix(docs): fix Edit this page on GitHub links on tools and pro-help - #2651

Merged
vtushar06 merged 1 commit into
json-schema-org:mainfrom
KartikManuja:fix/docshelp-edit-page-links
Nov 17, 2026
Merged

vtushar06 merged 1 commit into
json-schema-org:mainfrom
KartikManuja:fix/docshelp-edit-page-links

Conversation

@KartikManuja

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bugfix

Issue Number:

Screenshots/videos:

N/A

If relevant, did you update the documentation?

N/A

Summary

This PR resolves an issue where the "Edit this page on GitHub" link on the /tools and /overview/pro-help pages directed to non-existent markdown files, causing a 404 error on Pro-Help and redirecting to the directory tree on Tools.

Previously, both pages rendered <DocsHelp /> without fileRenderType="tsx", causing the component to default to .md extensions instead of linking to the actual index.page.tsx source files. This change passes fileRenderType='tsx' on both pages and strips URL query parameters in DocsHelp.tsx so active search/filter queries on /tools do not distort the GitHub link.

Does this PR introduce a breaking change?

No

Checklist

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview e7e2329

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b7b58b) to head (e7e2329).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          737       738    +1     
  Branches       229       229           
=========================================
+ Hits           737       738    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vtushar06
vtushar06 enabled auto-merge (squash) November 17, 2026 06:13
@vtushar06
vtushar06 disabled auto-merge November 17, 2026 06:13
@vtushar06
vtushar06 merged commit a2d03f7 into json-schema-org:main Nov 17, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to review to Done in PR - Triage Group Nov 17, 2026
vtushar06

This comment was marked as outdated.

This branch was successfully deployed

1 active deployment
Preview — e7e23295 Deployed Nov 14, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: "Edit this page on GitHub" link broken on /tools and /overview/pro-help

2 participants