Repository navigation
Conversation
It's imported in calendarUtils but only present because node-ical hoists it. Adding it to package.json keeps the homepage and community page builds from breaking when node-ical is upgraded. Signed-off-by: Drishty Raghav <273601396+drishtyraghav0001@users.noreply.github.com>
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 737 737
Branches 229 229
=========================================
Hits 737 737 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
LGTM @drishtyraghav0001 |
vtushar06
approved these changes
Nov 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
n/a, just a dependency declaration.
moment-timezoneis already installed through node-ical, this just lists it in package.json so an upgrade of node-ical can't break the build.If relevant, did you update the documentation?
no
Summary
lib/calendarUtils.tsimportsmoment-timezone, but it wasn't listed in package.json. it only works today becausenode-ical@0.20.1depends on it and it gets hoisted. newer node-ical dropped that dependency, so upgrading it would break the homepage and community page builds.added
moment-timezone@^0.5.45to dependencies, the same version already in the lockfile, so the resolved version doesn't change.Does this PR introduce a breaking change?
no
Checklist