Skip to content

fix: add moment-timezone to package.json - #2649

Merged
vtushar06 merged 1 commit into
json-schema-org:mainfrom
drishtyraghav0001:fix/add-moment-timezone-dependency
Nov 17, 2026
Merged

vtushar06 merged 1 commit into
json-schema-org:mainfrom
drishtyraghav0001:fix/add-moment-timezone-dependency

Conversation

@drishtyraghav0001

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bugfix

Issue Number:

Screenshots/videos:

n/a, just a dependency declaration. moment-timezone is already installed through node-ical, this just lists it in package.json so an upgrade of node-ical can't break the build.

If relevant, did you update the documentation?

no

Summary

lib/calendarUtils.ts imports moment-timezone, but it wasn't listed in package.json. it only works today because node-ical@0.20.1 depends on it and it gets hoisted. newer node-ical dropped that dependency, so upgrading it would break the homepage and community page builds.

added moment-timezone@^0.5.45 to dependencies, the same version already in the lockfile, so the resolved version doesn't change.

Does this PR introduce a breaking change?

no

Checklist

It's imported in calendarUtils but only present because node-ical
hoists it. Adding it to package.json keeps the homepage and community
page builds from breaking when node-ical is upgraded.

Signed-off-by: Drishty Raghav <273601396+drishtyraghav0001@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a15fb0e

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b7b58b) to head (a15fb0e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2649   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          737       737           
  Branches       229       229           
=========================================
  Hits           737       737           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vtushar06

Copy link
Copy Markdown
Collaborator

LGTM @drishtyraghav0001

@vtushar06
vtushar06 merged commit df0a44c into json-schema-org:main Nov 17, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to review to Done in PR - Triage Group Nov 17, 2026

This branch was successfully deployed

1 active deployment
Preview — a15fb0ee Deployed Nov 13, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: moment-timezone is imported but not declared in package.json

2 participants