Repository navigation
Hide empty parentheses in tool creator and maintainer lists - #2647
Open
sham-jadhav03 wants to merge 2 commits into
Open
sham-jadhav03 wants to merge 2 commits into
sham-jadhav03 wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 737 737
Branches 229 229
=========================================
Hits 737 737 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Hi @KartikManuja and @vtushar06! 👋 I have fixed the bug where empty parentheses were rendering for creators and maintainers without a username.
Could you please take a look when you have a moment? Thank you! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: only show creator and maintainer username links in parentheses when both a username and platform are available.
Issue Number:
Screenshots/videos:
Not applicable; this is a conditional text-rendering fix.
If relevant, did you update the documentation?
No documentation changes were needed.
Summary
Moves the parentheses and username link inside the existing username-and-platform condition for both Creators and Maintainers. Entries with only a name now show the name without empty parentheses; entries with profile details retain the
(@username)link.Validation:
npx --yes corepack@0.34.5 yarn eslint pages/tools/components/ToolingDetailModal.tsx --max-warnings 0 --rule '@typescript-eslint/type-annotation-spacing: off' --rule '@typescript-eslint/no-unused-vars: off'— passed.npx --yes corepack@0.34.5 yarn run lint— failed because the current ESLint configuration references the missing@typescript-eslint/type-annotation-spacingrule.npx --yes corepack@0.34.5 yarn run typecheck— failed on existing unresolved importscypress/react18andmoment-timezone.Does this PR introduce a breaking change?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.