Skip to content

Hide empty parentheses in tool creator and maintainer lists - #2647

Open
sham-jadhav03 wants to merge 2 commits into
json-schema-org:mainfrom
sham-jadhav03:fix/tooling-modal-empty-parentheses
Open

sham-jadhav03 wants to merge 2 commits into
json-schema-org:mainfrom
sham-jadhav03:fix/tooling-modal-empty-parentheses

Conversation

@sham-jadhav03

Copy link
Copy Markdown

What kind of change does this PR introduce?

Bug fix: only show creator and maintainer username links in parentheses when both a username and platform are available.

Issue Number:

Screenshots/videos:

Not applicable; this is a conditional text-rendering fix.

If relevant, did you update the documentation?

No documentation changes were needed.

Summary

Moves the parentheses and username link inside the existing username-and-platform condition for both Creators and Maintainers. Entries with only a name now show the name without empty parentheses; entries with profile details retain the (@username) link.

Validation:

  • npx --yes corepack@0.34.5 yarn eslint pages/tools/components/ToolingDetailModal.tsx --max-warnings 0 --rule '@typescript-eslint/type-annotation-spacing: off' --rule '@typescript-eslint/no-unused-vars: off' — passed.
  • npx --yes corepack@0.34.5 yarn run lint — failed because the current ESLint configuration references the missing @typescript-eslint/type-annotation-spacing rule.
  • npx --yes corepack@0.34.5 yarn run typecheck — failed on existing unresolved imports cypress/react18 and moment-timezone.

Does this PR introduce a breaking change?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 2fd6327

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ff13109) to head (2fd6327).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2647   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          737       737           
  Branches       229       229           
=========================================
  Hits           737       737           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sham-jadhav03

Copy link
Copy Markdown
Author

Hi @KartikManuja and @vtushar06! 👋

I have fixed the bug where empty parentheses were rendering for creators and maintainers without a username.

Could you please take a look when you have a moment? Thank you!

This branch was successfully deployed

1 active deployment
Preview — 2fd63279 Deployed Nov 13, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Empty parentheses shown after creators and maintainers who have no username

1 participant