Skip to content

Close theme dropdown after selection - #2642

Closed
Ajaykumar724 wants to merge 2 commits into
json-schema-org:mainfrom
Ajaykumar724:ajay
Closed

Ajaykumar724 wants to merge 2 commits into
json-schema-org:mainfrom
Ajaykumar724:ajay

Conversation

@Ajaykumar724

@Ajaykumar724 Ajaykumar724 commented Nov 10, 2026 •

Copy link
Copy Markdown

What kind of change does this PR introduce?

Bug fix: The theme dropdown now closes immediately after selecting Light, Dark, or System.

Issue Number:

Screenshots/videos:

Screen.Recording.2026-11-10.203356.mp4

If relevant, did you update the documentation?

No documentation update was needed.

Summary

Selecting a theme now applies the selection and closes the dropdown immediately, without requiring an additional click outside the menu. The Cypress component test now checks for this immediate close.

Does this PR introduce a breaking change?

No.

Checklist

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 5534269

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cefee55) to head (5534269).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2642   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          737       740    +3     
  Branches       229       229           
=========================================
+ Hits           737       740    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
Preview — 55342690 Deployed Nov 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Theme Selector Dropdown Remains Open After Selecting a Theme

2 participants