Repository navigation
ansible: unbind herdr close_pane - #399
Merged
Merged
Conversation
prefix+x sits next to prefix+c and closes the focused pane. The managed [keys] block now sets close_pane to an empty binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_panein the managed[keys]block ofsetup-herdr.yml.prefix+xsits next toprefix+c(new tab) and closes the focused pane, which removes a one-pane tab.herdr pane closestill close a pane.close_tabstays onprefix+shift+x.Test plan
bazel test --test_summary=terse //devtools/setup-dev/ansible:go_default_test --test_filter=TestHerdrSkippedOnTermux --test_output=errors(1 test passed)ansible-playbook --syntax-check devtools/setup-dev/ansible/setup-herdr.ymlherdr config checkandherdr server reload-config(reload statusapplied)make checkis greenmake checkpassed format checks andbazel test //...(330 tests). After rebuilding the localoserrorsgodernizeagainstgolang.org/x/toolsv0.52.0, lint failed on existingos.IsNotExistcalls inpackages_data_test.go. Those lines are outside this change.golangci-lint run ./...reported 0 issues.