Skip to content

Docs: Clarify DestinationRule spec.trafficPolicy.connectionPool.tcp.maxConnections #3509

Description

@virtualdxs

Bug description

The documentation for the DestinationRule field spec.trafficPolicy.connectionPool.tcp.maxConnections states the following:

Maximum number of HTTP1 /TCP connections to a destination host. Default 2^32-1.

This is misleading for two reasons:

  1. It seems to imply that HTTP/2 connections are not subject to this limit, which per Envoy's docs doesn't seem to be the case
  2. This is much more of a nitpick, but per Envoy's docs it's technically possible to surpass this limit, so it may be worth adding a caveat about that.

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions