Skip to content

[raft] Add tests in CI - #1538

Merged
mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:raft_tests_in_ci
Sep 28, 2026
Merged

mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:raft_tests_in_ci

Conversation

@the-glu

@the-glu the-glu commented Jun 16, 2026 •

Copy link
Copy Markdown
Member

This PR follows #1536.

Adds automatic CI tests using raft as a datastore.

Evict tests are not enabled yet, as evict is still a TODO for raft.

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider setting up a job matrix to deduplicate CRDB-YBDB-raft.

@MariemBaccari
MariemBaccari force-pushed the raft_tests_in_ci branch 2 times, most recently from 6edf0cd to 7217ad0 Compare September 15, 2026 16:03
@MariemBaccari

Copy link
Copy Markdown
Contributor

Implements #1703

@MariemBaccari
MariemBaccari force-pushed the raft_tests_in_ci branch 8 times, most recently from f11c0c8 to 3930855 Compare September 28, 2026 07:48

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments

Comment thread .github/workflows/ci.yml Outdated
run: make probe-locally
- name: Run Qualifier against local DSS instance
run: make qualify-locally
# Todo: Re add evict tests here once evict is implemented.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure it's tracked in the issue the CI job needs update, and reference the issue no. here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated #1718 's description

Comment thread .github/workflows/ci.yml Outdated
- name: Bring down local DSS instance
run: make down-locally

dss-tests-with-raft:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to test matrix above instead? Temporarily not running the evict should be doable with an if.

@MariemBaccari
MariemBaccari force-pushed the raft_tests_in_ci branch 3 times, most recently from ac3969e to dd0ec1f Compare September 28, 2026 11:56
@mickmis
mickmis merged commit 408874a into interuss:master Sep 28, 2026
19 checks passed
@mickmis
mickmis deleted the raft_tests_in_ci branch September 28, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dss-raft Relating to the application-layer consensus implemenation based on raft

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants