[raft] Add tests in CI - #1538
Merged
Merged
[raft] Add tests in CI #1538
Conversation
the-glu
force-pushed
the
raft_tests_in_ci
branch
from
June 16, 2026 12:28
e5f285a to
20110d0
Compare
the-glu
force-pushed
the
raft_tests_in_ci
branch
2 times, most recently
from
June 22, 2026 12:18
f42d605 to
a77b08d
Compare
the-glu
marked this pull request as ready for review
June 22, 2026 12:18
This was referenced Jun 22, 2026
mickmis
approved these changes
Sep 2, 2026
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but consider setting up a job matrix to deduplicate CRDB-YBDB-raft.
the-glu
force-pushed
the
raft_tests_in_ci
branch
from
September 11, 2026 15:14
a77b08d to
ac609f9
Compare
MariemBaccari
force-pushed
the
raft_tests_in_ci
branch
2 times, most recently
from
September 15, 2026 16:03
6edf0cd to
7217ad0
Compare
Contributor
|
Implements #1703 |
MariemBaccari
force-pushed
the
raft_tests_in_ci
branch
8 times, most recently
from
September 28, 2026 07:48
f11c0c8 to
3930855
Compare
mickmis
approved these changes
Sep 28, 2026
| run: make probe-locally | ||
| - name: Run Qualifier against local DSS instance | ||
| run: make qualify-locally | ||
| # Todo: Re add evict tests here once evict is implemented. |
Contributor
There was a problem hiding this comment.
Ensure it's tracked in the issue the CI job needs update, and reference the issue no. here.
| - name: Bring down local DSS instance | ||
| run: make down-locally | ||
|
|
||
| dss-tests-with-raft: |
Contributor
There was a problem hiding this comment.
Add to test matrix above instead? Temporarily not running the evict should be doable with an if.
MariemBaccari
force-pushed
the
raft_tests_in_ci
branch
3 times, most recently
from
September 28, 2026 11:56
ac3969e to
dd0ec1f
Compare
MariemBaccari
force-pushed
the
raft_tests_in_ci
branch
from
September 28, 2026 13:18
dd0ec1f to
4e02307
Compare
mickmis
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #1536.
Adds automatic CI tests using raft as a datastore.
Evict tests are not enabled yet, as evict is still a TODO for raft.