docs: fix duplicate network anchor IDs - #665
Open
callumweb3 wants to merge 1 commit into
Open
Conversation
`AddNetworkButton` is rendered twice in `src/pages/general/connect-wallet.mdx` for `mainnet` and `sepolia` (approximately lines 7–9), while `NetworkType` explicitly defines these as separate network values in `src/utils/networks.ts` (approximately line 3). Previously, the component used a hardcoded `id="mainnet"` and `href="#mainnet"`, causing both rendered sections to use the same anchor target. Updated `src/components/AddNetworkButton.tsx` (approximately lines 31–36) to generate the anchor from the existing `network` prop: * `mainnet` > `#mainnet` * `sepolia` > `#sepolia` Also removed the unused `CheckIcon` import. This gives each network section a unique anchor and removes the unused import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddNetworkButtonis rendered twice insrc/pages/general/connect-wallet.mdxformainnetandsepolia, whileNetworkTypeexplicitly defines these as separate network values insrc/utils/networks.ts.Previously, the component used a hardcoded
id="mainnet"andhref="#mainnet", causing both rendered sections to use the same anchor target.Updated
src/components/AddNetworkButton.tsxto generate the anchor from the existingnetworkprop:mainnet>#mainnetsepolia>#sepoliaAlso removed the unused
CheckIconimport.This gives each network section a unique anchor and removes the unused import.