Repository navigation
fix(api): remove incorrect 양정 default on GET /school - #9
Merged
Merged
Conversation
The OpenAPI description claimed schoolname defaulted to 양정고등학교 when omitted. schoolname is now required in the schema and handler, matching other endpoints. Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Mark client/ and api/ as Fumadocs root folders for layout tabs - Document required schoolname/schoolcode; no default school - Replace 양정 examples with 목운중학교 in client docs and OpenAPI schemas Co-authored-by: Injoon Oh <injoon5@icloud.com>
injoon5
marked this pull request as ready for review
May 26, 2026 16:14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /schooldefaults to 양정고등학교 whenschoolnameis omittedroot: trueon foldermeta.jsonfilesChanges
API
schoolnamerequired onGET /schoolDocs site
content/docs/meta.json:index,client,apionly (tabs replace---Client---/---HTTP API---separators)client/meta.json+api/meta.json:"root": truefor sidebar layout tabsschoolname/schoolcode, no default schoolSchemas
SchoolNameexamples/descriptions updated; response examples use 목운중학교Verification
npm run openapi:syncnpm run build:docsnpm test