Repository navigation
fix: school search fails for partial names like 양정 - #11
Merged
Merged
Conversation
NEIS omits HS_GNRL_BUSNS_SC_NM for some elementary schools (e.g. 거제양정초등학교). Partial name searches like 양정 return mixed school types, so response validation failed even though NEIS data was valid. Make the field optional in SchoolInfoRowSchema and add a regression test. Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /school?schoolname=양정returned aVALIDATION_ERROReven though NEIS returned valid data. The handler found 10 matching schools, but Elysia response validation rejected the payload.Root cause: some elementary schools (e.g. 거제양정초등학교) omit
HS_GNRL_BUSNS_SC_NM, which ourSchoolInfoRowSchemarequired. Partial-name searches return mixed school types, so one missing field failed the entire response.Fix
HS_GNRL_BUSNS_SC_NMoptional inSchoolInfoRowSchemaSchoolInfoRowclient type (HS_GNRL_BUSNS_SC_NM?: string | null)양정Verification
npm test— all structural checks pass, including new partial-name casenpm run buildGET /school?schoolname=양정returns 200 with 10 schools