Repository navigation
Conversation
github-actions
Bot
added
models
tests
hooks
fixes-issue
size/L
sayakpaul
changed the title
sayakpaul
commented
Nov 11, 2026
| parallel_config | ||
| if isinstance(parallel_config, TensorParallelConfig) | ||
| else parallel_config.tensor_parallel_config | ||
| else getattr(parallel_config, "tensor_parallel_config", None) |
Member
Author
There was a problem hiding this comment.
To support passing bare ContextParallelConfig to from_pretrained() just like TensorParallelConfig.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
@yzhautouskay could you test the Cosmos PR with this one instead of the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15218.
Instead of
Optional, I opted forConditionalto avoid conflicts with Python typing.Decided to test it in a standalone manner rather than generalizing through
tests/models/testing_utils/parallelism.pyto keep things simple.I have run the entire TP and CP test suite and they pass as expected.