Skip to content

[docs/CI] contribution guide update, adding a context item on issue template, update issue-link reminder - #15179

Merged
yiyixuxu merged 7 commits into
mainfrom
linked-issue-self-opened
Nov 6, 2026
Merged

yiyixuxu merged 7 commits into
mainfrom
linked-issue-self-opened

Conversation

@yiyixuxu

@yiyixuxu yiyixuxu commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

this PR:

1. Ask for "Context" in the issue templates

Adding a new optional Context field on the bug report: what project were you working on when you run into this issue? The motivation is to help us prioritize our work. i.e. we want to focus more on issues users run into when they building an app on top of Diffusers, than the theoretical ones.

2. Update on the issue-link reminder bot

I notice a lot of times model authors don't check the author box and end up getting the bot reminder, see an example #15155 (comment). So in this PR I added instructions to the reminder for that scenario (tell them to check the box and the reminder no longer applies etc). Also updated the wording of the author box a little, since the teams/contributors we work with do not necessarily consider themselves "model authors", it is now Are you the author (or part of the team we work with) of the model/pipeline this PR relates to?.

The other thing that happens a lot: the contributor opens an issue themselves and link to the PR after seeing the reminder. we should not count these as linked since they are not existing issues and we did not have a discussion first, so these PR stays on the Slack rescue route despite the fact that now linked to an issue.

3. Contribution guide rewrite

I went over the contribution guide and updated as much as I can for contents that're outdated:

  1. remove the forum, we are using GitHub Discussions now
  2. remove the section on contributing a community pipeline, replaced with publishing a modular pipeline/model on the Hub as remote code
  3. make sure we always ask them to discuss first (the guide used to say "feel free to open a PR directly" in a few places). "How to write a good PR" now starts from an issue (issue → discussion → PR) - we don't enforce the discussion-first rule, e.g. if the PR comes for an issue we still review it, but we prefer to have a discussion first and so should say so in our contribution guide
  4. moved some general rules that only lived in the AI section (fix patterns not one-offs, write the description for the reviewer, run self-review) into the general contribution guide as well, I think these applies to all contributors. the self-review part you need a AI but we highly recommend it as part of the contribution workflow; the AI section keeps only what is most relevant to agents
  5. make it clear that the workflow for community to contribute a new model/pipeline is to have a remote hub node first instead of directly open a PR

yiyixuxu and others added 2 commits October 21, 2026 09:30
Applies to both the fixes-issue label and the issue-link reminder.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ms, clearer reminder bot

- Contribution guide: overview reordered by time commitment (Discussions replaces
  the forum, community pipelines replaced by publishing on the Hub, MVP issues
  and library integration as their own items); "How to write a good PR" now
  starts from an issue and folds in the general rules from the AI section;
  "How to write a good issue" asks for context and links the reporting guide.
- Issue forms: optional Context field on the bug report, project context in
  the feature request's additional context, reporting guide linked from the
  reproduction field.
- PR template: generic author/team checkbox wording.
- Reminder bot: tells authors how to clear it (link an existing issue, tick the
  author box, or wait for `no-issue-needed`), and that an issue opened after
  the PR does not count.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation CI size/L PR with diff > 200 LOC labels Nov 4, 2026
Comment thread .github/ISSUE_TEMPLATE/bug-report.yml Resolved
Comment thread .github/ISSUE_TEMPLATE/bug-report.yml Resolved
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Pages changed in this PR:

You can contribute in many ways ranging from answering questions on issues and discussions to adding new diffusion models to the core library.

In the following, we give an overview of different ways to contribute, ranked by difficulty in ascending order. All of them are valuable to the community.
In the following, we give an overview of different ways to contribute, ranked by the time commitment required, in ascending order. All of them are valuable to the community.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "difficulty" to "time commitment required" e.g. I don't think creating an issue is necessarily more difficult than fixing it, not anymore

In the following, we give an overview of different ways to contribute, ranked by difficulty in ascending order. All of them are valuable to the community.
In the following, we give an overview of different ways to contribute, ranked by the time commitment required, in ascending order. All of them are valuable to the community.

* 1. Asking and answering questions on [the Diffusers discussion forum](https://discuss.huggingface.co/c/discussion-related-to-httpsgithubcomhuggingfacediffusers) or on [Discord](https://discord.gg/G7tWnz98XR).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the mention of the forum since we are not actively using it anymore

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvements!

Comment on lines +41 to +44
attributes:
label: Context
description: What were you working on when you run into this issue? A little bit of context helps us understand the impact and prioritize. A link to the project is great if you have one, not required.
placeholder: "Working on X [link], run into this issue when ..."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice addition!

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating and improving!

yiyixuxu and others added 3 commits November 6, 2026 08:08
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@yiyixuxu
yiyixuxu merged commit 0fccef1 into main Nov 6, 2026
14 of 15 checks passed
@yiyixuxu
yiyixuxu deleted the linked-issue-self-opened branch November 6, 2026 18:42
yiyixuxu added a commit that referenced this pull request Nov 6, 2026
The forum category has not been used in a long time; the contribution guide
moved to GitHub Discussions in #15179. This catches the three mentions left:
the PR template checkbox, the translation issue template, and the controlling
generation guide.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI documentation Improvements or additions to documentation size/L PR with diff > 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants