Fix bug: Windows guard in is_available() compares os.system (a function) to 'nt' — always False - #1917
Draft
vinayK34 wants to merge 1 commit into
Draft
Fix bug: Windows guard in is_available() compares os.system (a function) to 'nt' — always False#1917vinayK34 wants to merge 1 commit into
vinayK34 wants to merge 1 commit into
Conversation
…on) to 'nt' — always False The comparison `os.system == 'nt'` was incorrect because `os.system` is a built-in function, not a string. This caused the Windows guard to never trigger, meaning man pages would be attempted to be displayed on Windows systems despite the intention to skip them. Changed to `sys.platform == 'win32'` which is the most robust way to detect Windows platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
httpie/output/ui/man_pages.pywhere the Windows platform check was incorrect. The comparisonos.system == 'nt'was comparing a built-in function to a string, which is alwaysFalse. This meant that the Windows guard never triggered, causing man pages to be attempted to be displayed on Windows systems despite the intention to skip them.Changes
os.system == 'nt'tosys.platform == 'win32'for proper Windows platform detectionimport systo support the platform checkImpact
This fix ensures that man pages are properly skipped on Windows systems, preventing unnecessary errors and improving the user experience on Windows platforms where
mancommands are typically not available.