Skip to content

v2.2.3 - #1130

Merged
bwp91 merged 2 commits into
latestfrom
beta-2.2.3
Aug 22, 2026
Merged

v2.2.3#1130
bwp91 merged 2 commits into
latestfrom
beta-2.2.3

Conversation

@bwp91

@bwp91 bwp91 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Changes

Homebridge Dependencies

  • @homebridge/ciao @ v1.3.12
  • @homebridge/dbus-native @ v0.7.9
  • bonjour-hap @ v3.10.5

@bwp91
bwp91 requested review from NorthernMan54 and a lite review from Copilot August 22, 2026 13:18
@coveralls

coveralls commented Aug 22, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 32580805941

Coverage increased (+0.3%) to 66.753%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: 47 of 47 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 9671
Covered Lines: 6772
Line Coverage: 70.02%
Relevant Branches: 3461
Covered Branches: 1994
Branch Coverage: 57.61%
Branches in Coverage %: Yes
Coverage Strength: 364.86 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This release PR hardens HAP-NodeJS against malformed characteristic perms data originating from plugins, preventing a single bad bridged accessory from breaking the entire bridge’s HomeKit representation.

Changes:

  • Add runtime validation and safe diagnostics for characteristic permission arrays (perms), including resilient formatting for malformed values.
  • Quarantine bridged accessories with invalid permissions at the serving boundary (while rejecting publish for standalone/root accessories with invalid perms).
  • Update dependency ranges for select Homebridge dependencies and bump dev tooling (eslint), plus changelog entry.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/lib/Characteristic.ts Adds perms validation/diagnostics and ensures warnings are emitted even when no listeners are attached yet.
src/lib/Characteristic.spec.ts Adds unit tests for permission validation, diagnostics formatting, and warning behavior.
src/lib/Accessory.ts Implements bridged-accessory quarantine based on invalid permission arrays; blocks publishing invalid standalone accessories.
src/lib/Accessory.spec.ts Adds tests covering quarantine behavior, config update enqueueing, and publish blocking.
package.json Adjusts dependency specifiers for select runtime deps and updates eslint.
package-lock.json Lockfile updates reflecting dependency range and version changes.
CHANGELOG.md Documents the fix and dependency updates for the release notes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/lib/Characteristic.ts Outdated
Comment thread src/lib/Characteristic.ts Dismissed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Comment thread src/lib/Characteristic.ts Outdated
Comment thread src/lib/Characteristic.ts Outdated
bwp91 and others added 2 commits August 22, 2026 16:07
…ridge (#1129)

Co-Authored-By: hjdhjd <hjdhjd@users.noreply.github.com>
Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
@bwp91
bwp91 merged commit 57ce717 into latest Aug 22, 2026
26 checks passed
@bwp91
bwp91 deleted the beta-2.2.3 branch August 22, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants