Repository navigation
v2.2.3 - #1130
Merged
Merged
v2.2.3#1130
Conversation
Coverage Report for CI Build 32580805941Coverage increased (+0.3%) to 66.753%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This release PR hardens HAP-NodeJS against malformed characteristic perms data originating from plugins, preventing a single bad bridged accessory from breaking the entire bridge’s HomeKit representation.
Changes:
- Add runtime validation and safe diagnostics for characteristic permission arrays (
perms), including resilient formatting for malformed values. - Quarantine bridged accessories with invalid permissions at the serving boundary (while rejecting publish for standalone/root accessories with invalid perms).
- Update dependency ranges for select Homebridge dependencies and bump dev tooling (eslint), plus changelog entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib/Characteristic.ts | Adds perms validation/diagnostics and ensures warnings are emitted even when no listeners are attached yet. |
| src/lib/Characteristic.spec.ts | Adds unit tests for permission validation, diagnostics formatting, and warning behavior. |
| src/lib/Accessory.ts | Implements bridged-accessory quarantine based on invalid permission arrays; blocks publishing invalid standalone accessories. |
| src/lib/Accessory.spec.ts | Adds tests covering quarantine behavior, config update enqueueing, and publish blocking. |
| package.json | Adjusts dependency specifiers for select runtime deps and updates eslint. |
| package-lock.json | Lockfile updates reflecting dependency range and version changes. |
| CHANGELOG.md | Documents the fix and dependency updates for the release notes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ridge (#1129) Co-Authored-By: hjdhjd <hjdhjd@users.noreply.github.com> Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
NorthernMan54
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Homebridge Dependencies
@homebridge/ciao@v1.3.12@homebridge/dbus-native@v0.7.9bonjour-hap@v3.10.5