Repository navigation
fix(deps): update tfo-go to v2.4.2 for Go 1.27 (Windows crash) - #162
Merged
Merged
Conversation
On Windows, tfo-go v2.3.2 links to internal/poll.(*FD).execIO with the signature of an older Go (a buf []byte last argument). Go 1.27.3 takes pinPtrs ...any there, so with TCP Fast Open a failed dial or handshake returned a broken error, and the core crashed as soon as it read it (in the URL test's log, or in errors.As in the TLS dialer). Large subscriptions crashed within a second of starting. v2.4.2 matches Go 1.27.3. With the same 6,000-proxy profile the core ran without a crash, and failed dials through TCP Fast Open (refused, timeout, TLS errors) were logged normally. golang.org/x/sys moves to v0.49.0, which tfo-go v2.4.2 requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows the core crashed with large subscriptions, usually within a second of starting (
nil pointer dereferenceinnet.(*OpError).Errororerrors.As).The cause is TCP Fast Open. tfo-go v2.3.2 links to Go's internal
internal/poll.(*FD).execIOwith an older signature (buf []byte), but Go 1.27.3 takespinPtrs ...any. When a dial or handshake through TCP Fast Open failed, the returned error was broken, and the core crashed as soon as it read it.Fix
tfo-go v2.4.2, which matches Go 1.27.3.
golang.org/x/sysgoes to v0.49.0, which it requires.Test
tcp_fast_open.🤖 Generated with Claude Code