Repository navigation
refactor(hcore): plain proxy lists with chain_hop; Connected waits for the hop - #161
Merged
Merged
Conversation
Monitoring no longer loads the saved IP information at start, so OutboundInfo.ipinfo is empty until a lookup of this run works, and a failed first test or lookup no longer keeps the old IP for the whole run (hiddify-sing-box 0947d32ea). The app's home card now shows its loading state instead of last run's exit IP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The main proxy list gets one field for the extra security or unblocker hop the traffic goes through now, so clients read the hop directly instead of finding it among renamed copies. hcore.pb.go is generated with protoc-gen-go v1.34.2, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The proxy lists no longer rewrite what they send:
- names and types are no longer joined with the detour ("A → B"), nor a
group's entry with its pick in the main list; detour holds the tag
- the extra security hop is no longer put first in select, so select
keeps its real selection
- no chain-hops group with renamed copies, and no renamed members in
the chain groups
The main list sets chain_hop to the hop itself; in the selectable mode it
follows the selector and its balancer down to the hop. The status mark
stays in type: the proxy list shows it.
This also fixes names such as "Via P → P socks → Via P" and
"P socks → Unblocker → P socks → P socks", which the joins produced
when one proxy was in several groups.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With extra security all traffic goes through the hop, which dials through the selected proxy. The core reported STARTED as soon as the lowest group had a ping, while the hop was still connecting, so clients showed Connected before anything worked. Now STARTED also needs a live ping of the hop the traffic goes through (the one chain_hop reports); otherwise the core stays WAITING. The unblocker needs no such check: the proxies dial through it, so their own pings cover it. Checked with grpcurl on Psiphon, WARP and the selectable mode: STARTED comes right after the hop's first ping, never before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on hiddify/hiddify-sing-box#43: the first commit bumps hiddify-sing-box to a commit on that PR's branch.
Changes (4 commits)
Bump hiddify-sing-box: monitoring no longer loads the IP of the previous run, so
ipinfostays empty until a lookup of this run works.chain_hopinOutboundGroupList: the main list sends the active extra security / unblocker hop in its own field.Each proxy sent as it is:
select;chain-hopsgroup with renamed copies.detourstill names the next hop. The status mark stays intype, because the proxy list shows it. This also fixes broken names such asVia P → P socks → Via P.Connected waits for the hop: with extra security,
STARTEDneeds a live ping of the hop too. Before, the core said Connected while the hop was still connecting.Tests
chain_hopis right in every chain case, andSTARTEDcomes right after the hop's first ping.Note
Breaking for clients: the app must read
chain_hop. The matching app change is not in a PR yet.🤖 Generated with Claude Code