Repository navigation
[LOW] Handle malformed Windows Media Player versions - #78
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security impact (LOW)
Unversioned or malformed Windows Media Player products are valid parser inputs, but
classic?,os,mobile?, andto_hcompared a missing or nonnumeric major component with an integer and raised. A request-controlled User-Agent can therefore create application errors wherever this metadata is rendered.The failure is request-local, so the impact is low.
Fix
Treat only integer major versions up to 4 as classic. Missing and nonnumeric components remain non-classic and use the existing generic Windows fallback.
Verification
NSPlayer,NSPlayer/.1.0.3856, classic 4.x, and 9.x models return metadata without exceptions.Breaking changes
None. Previously failing malformed versions now return conservative metadata.