Skip to content

[LOW] Handle malformed Windows Media Player versions - #78

Open
OskarEichler wants to merge 2 commits into
gshutler:masterfrom
OskarEichler:codex/handle-unversioned-wmp
Open

OskarEichler wants to merge 2 commits into
gshutler:masterfrom
OskarEichler:codex/handle-unversioned-wmp

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 30, 2026 •

Copy link
Copy Markdown

Security impact (LOW)

Unversioned or malformed Windows Media Player products are valid parser inputs, but classic?, os, mobile?, and to_h compared a missing or nonnumeric major component with an integer and raised. A request-controlled User-Agent can therefore create application errors wherever this metadata is rendered.

The failure is request-local, so the impact is low.

Fix

Treat only integer major versions up to 4 as classic. Missing and nonnumeric components remain non-classic and use the existing generic Windows fallback.

Verification

  • Existing suite: 1,321 examples, 0 failures on Ruby 4.0.6 and 3.2.11.
  • Focused NSPlayer, NSPlayer/.1.0.3856, classic 4.x, and 9.x models return metadata without exceptions.
  • Combined targeted mutation pass: 2,966 variants derived from 175 existing corpus agents, 0 exception classes after all related robustness patches.

Breaking changes

None. Previously failing malformed versions now return conservative metadata.

@OskarEichler OskarEichler changed the title Handle unversioned Windows Media Player agents [LOW] Handle malformed Windows Media Player versions Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant