fix: Make the Telemetry API enablement check non-fatal in AdkApp.set_up(). - #7073
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix: Make the Telemetry API enablement check non-fatal in AdkApp.set_up().#7073copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
size: l
…up(). `_warn_if_telemetry_api_disabled()` is a warning-only diagnostic, but it ran with no timeout and no exception handling on the agent server's startup path, so a single failed request to the Telemetry API could stop an agent from starting. Wrap the check so any failure degrades to a warning, and bound the request at 5 seconds. PiperOrigin-RevId: 964451485
copybara-service
Bot
force-pushed
the
copybara_964451485
branch
from
August 14, 2026 05:33
79089ac to
ccbcb7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Make the Telemetry API enablement check non-fatal in AdkApp.set_up().
_warn_if_telemetry_api_disabled()is a warning-only diagnostic, but it ranwith no timeout and no exception handling on the agent server's startup path,
so a single failed request to the Telemetry API could stop an agent from
starting. Wrap the check so any failure degrades to a warning, and bound the
request at 5 seconds.