feat(storage): add OpenTelemetry counters for read hedging - #16410
feat(storage): add OpenTelemetry counters for read hedging#16410ajayky-os wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry metrics tracking for read hedging operations in HedgedObjectReadSource, introducing a new HedgedReadMetrics helper class. The review feedback highlights several style guide violations and optimization opportunities, including avoiding auto when it obscures return types, declaring loop variables in the narrowest scope, removing unnecessary braces for short if statements, and passing nullptr instead of creating a new metrics instance in the delegating constructor to avoid performance overhead.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16410 +/- ##
==========================================
+ Coverage 92.25% 92.28% +0.03%
==========================================
Files 2246 2246
Lines 212528 212668 +140
==========================================
+ Hits 196060 196259 +199
+ Misses 16468 16409 -59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0369e56 to
987aa8f
Compare
987aa8f to
994c407
Compare
994c407 to
ec00415
Compare
ec00415 to
345e324
Compare
345e324 to
b86cceb
Compare
b86cceb to
54f0996
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry metrics for read hedging operations by adding a new HedgedReadMetrics class and integrating it into HedgedObjectReadSource and StorageConnectionImpl. The review feedback suggests optimizing the implementation by passing std::shared_ptr<HedgedReadMetrics> directly and using null checks instead of allocating dummy metrics on the heap when telemetry is disabled or not provided.
54f0996 to
f4c9e07
Compare
f4c9e07 to
112a78d
Compare
112a78d to
d0556cf
Compare
d0556cf to
3e588ad
Compare
Add storage.read_hedging.hedges_dispatched and storage.read_hedging.hedge_won counters to track speculative attempts and secondary hedge wins.
3e588ad to
ff17b17
Compare
Add storage.read_hedging.hedges_dispatched and storage.read_hedging.hedge_won counters to track speculative attempts and secondary hedge wins.