Use _LIBCPP_HAS_C11_ALIGNED_ALLOC to gate posix_memalign fallback in aligned_alloc_at_least. - #640
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Use _LIBCPP_HAS_C11_ALIGNED_ALLOC to gate posix_memalign fallback in aligned_alloc_at_least.#640copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…aligned_alloc_at_least. _ISOC11_SOURCE is a glibc feature test macro undefined in standard C++ builds, inadvertently forcing the posix_memalign fallback. Instead, check _LIBCPP_HAS_C11_ALIGNED_ALLOC to only fall back to posix_memalign when std::aligned_alloc is unavailable. PiperOrigin-RevId: 975469931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use _LIBCPP_HAS_C11_ALIGNED_ALLOC to gate posix_memalign fallback in aligned_alloc_at_least.
_ISOC11_SOURCE is a glibc feature test macro undefined in standard C++ builds, inadvertently forcing the posix_memalign fallback. Instead, check _LIBCPP_HAS_C11_ALIGNED_ALLOC to only fall back to posix_memalign when std::aligned_alloc is unavailable.