Repository navigation
Update PathValue and docs - #2
Merged
Merged
Conversation
Signed-off-by: Chen Su <ghosind@gmail.com>
Signed-off-by: Chen Su <ghosind@gmail.com>
Signed-off-by: Chen Su <ghosind@gmail.com>
Signed-off-by: Chen Su <ghosind@gmail.com>
Signed-off-by: Chen Su <ghosind@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR simplifies the PathValue/SetPathValue implementation by delegating to the underlying http.Request methods instead of maintaining a separate pathValue map, updates the engine dependency to v0.0.1, adds a README, and updates the CI Go version matrix.
Changes:
- Replaced the custom
pathValuemap inRequestwith delegation tohttp.Request.PathValue/SetPathValue. - Added a new
README.mdwith installation, usage, contributing, and license sections. - Updated CI matrix to test Go 1.24, 1.25, and 1.26 (dropping 1.23).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| request.go | Removed pathValue map field; PathValue/SetPathValue now delegate to http.Request |
| go.mod / go.sum | Bumped go-amwk/engine dependency from pre-release to v0.0.1 |
| README.md | Added project documentation with install, usage example, contributing guide, and license |
| .github/workflows/test.yml | Updated Go version matrix: removed 1.23, added 1.26 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Chen Su <ghosind@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following updates:
http.Request.