test(django): Remove two tests made redundant by existing coverage - #7159
Draft
ericapisani wants to merge 2 commits into
Draft
test(django): Remove two tests made redundant by existing coverage#7159ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
The json/str scalar row takes the same request-body extraction branch as the json/int scalar row already in the table and asserts the same shape, so it only re-runs coverage the int row provides.
It is a strict subset of test_query_source: same view, same db_query_source_threshold_ms, and a subset of its assertions. Its only distinct contribution was pinning that query source attributes are attached when enable_db_query_source is left at its default, so test_query_source now relies on the default rather than setting it explicitly, keeping that pin.
ericapisani
changed the title
Contributor
Codecov Results 📊✅ 102663 passed | ⏭️ 6587 skipped | Total: 109250 | Pass Rate: 93.97% | Execution Time: 355m 46s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2477 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.15% 90.15% —%
==========================================
Files 193 193 —
Lines 25147 25147 —
Branches 9136 9136 —
==========================================
+ Hits 22669 22670 +1
- Misses 2478 2477 -1
- Partials 1431 1430 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_query_source_enabledis a strict subset oftest_query_source— same view, same threshold, a subset of its assertions. Its one distinct contribution was pinning behaviour whenenable_db_query_sourceis left at its default, sotest_query_sourcenow relies on the default rather than setting it explicitly.json/strrow intest_rest_framework_basictakes the same body-extraction branch as thejson/introw and asserts the same shape.320 -> 312 cases.
Refs PY-2641
Refs #6975