test(django): Drop span_streaming parametrize where the arm is inert - #7157
Draft
ericapisani wants to merge 1 commit into
Draft
test(django): Drop span_streaming parametrize where the arm is inert#7157ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
These tests are event-only: they capture events, never spans, and the span_streaming argument was only ever fed to trace_lifecycle. Both arms therefore exercised identical code paths and asserted identical payloads, so the parametrize doubled the case count without adding coverage. Affected: 18 event-only tests in test_basic.py, the 3 cookie-scrubbing tests in test_data_scrubbing.py, test_set_db_data_custom_backend, and test_cache_spans_get_span_name (a pure unit test of _get_span_description that never referenced the argument). Tests that inspect spans or transactions keep their parametrize.
Contributor
Codecov Results 📊✅ 103319 passed | ⏭️ 6677 skipped | Total: 109996 | Pass Rate: 93.93% | Execution Time: 354m 44s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2477 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.15% 90.15% —%
==========================================
Files 193 193 —
Lines 25147 25147 —
Branches 9136 9136 —
==========================================
+ Hits 22669 22670 +1
- Misses 2478 2477 -1
- Partials 1431 1430 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These tests are event-only: they capture events, never spans, and the
span_streamingargument was only ever fed totrace_lifecycle. Both arms exercised identical code paths and asserted identical payloads, so the parametrize doubled the case count without adding coverage.Tests that inspect spans or transactions keep their parametrize.
391 -> 356 cases.
Refs PY-2641
Refs #6975