ref(httpx,httpx2): Move crumbs to integrations - #7149
Open
sentrivana wants to merge 8 commits into
Open
Conversation
sentrivana
commented
Aug 10, 2026
| "reason": rv.reason_phrase, | ||
| } | ||
|
|
||
| if parsed_url and (not is_span_streaming_enabled or should_send_default_pii()): |
Contributor
Author
There was a problem hiding this comment.
The is_not_span_streaming_enabled part is there for continuity in transaction mode, where we don't care about should_send_default_pii before setting breadcrumb data.
Contributor
Codecov Results 📊✅ 105070 passed | ⏭️ 6677 skipped | Total: 111747 | Pass Rate: 94.02% | Execution Time: 358m 14s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2479 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.15% 90.17% +0.02%
==========================================
Files 193 193 —
Lines 25147 25207 +60
Branches 9136 9160 +24
==========================================
+ Hits 22669 22728 +59
- Misses 2478 2479 +1
- Partials 1431 1431 —Generated by Codecov Action |
sentrivana
added a commit
that referenced
this pull request
Aug 10, 2026
Instead of parametrizing on sync/async httpx(2) client, split each test case into a sync and async variant, with the async variant as a proper `async def` function with `@pytest.mark.parametrize`. I did this because the tests routinely fail for me locally, and switching to using `pytest-asyncio` fixes that. The other reason is that for #7149, the breadcrumb tests don't simulate async very well, which leads to some scope problems and ultimately breadcrumbs not appearing on events in tests. I know this PR is not ideal since with the existing test duplication on span streaming/transaction tracing, we already have a LOT of test cases, and now many of them get an additional variant. But it does make them more resilient to random local (and I believe also CI) failures and we'll get rid of half of them on the new major branch.
ericapisani
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move breadcrumbs from the centralized, span-powered
maybe_create_breadcrumbs_from_spandirectly to the HTTPX and HTTPX2 integrations. (Put the two together in one PR since they're the same changeset.)Additional changes and context:
pytest-asyncio, as that simulates how the scopes behave live better than setting up an ad-hoc event loop.send_default_piibehavior).Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)