Restore prior focus after programmatic rename dialogs close - #3218
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Restore prior focus after programmatic rename dialogs close#3218bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The controlled rename shell can be opened without a registered dialog trigger. Its desktop close path therefore has no target for the primitive's default focus restoration, and the shell did not retain the element that was active before open. The verified investigation is published at https://get-bb.github.io/reports/issues/3217.html.
What changed
The shared application rename shell now captures the active element before moving focus into the rename field. After the dialog closes, it restores that element when it is still connected and outside hidden or inert content. A focused DOM regression test covers the programmatic open and close sequence.
How you verified
pnpm exec turbo run test --filter=@bb/app -- src/components/dialogs/RenameDialog.test.tsxfailed becausedocument.bodyretained focus instead of the composer.pnpm exec turbo run test typecheck lint build --filter=@bb/apppassed: 481 test files and 3,927 tests passed, with 3 skipped; typecheck, lint, and build also completed successfully.pnpm exec oxfmt --check apps/app/src/components/dialogs/RenameDialog.tsx apps/app/src/components/dialogs/RenameDialog.test.tsxpassed.git diff --checkpassed.Fixes #3217