Yield completed-output retention work between bounded steps - #3202
Closed
bb-slop-cop[bot] wants to merge 1 commit into
Closed
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
Collaborator
|
Closing as stale: main replaced the targeted retention implementation with bounded output migration/sweep work that yields. This does not establish that every broader performance concern in #3196 is resolved. Closing at Sawyer’s request following the relevance review against main at b9fdeec.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The completed-output retention job passed the full 250-row limit into synchronous SQLite JSON scans and updates in one event-loop turn. Its generic asynchronous work frame also excluded that synchronous body from blocking-work attribution. The direct reproduction and root-cause report is https://get-bb.github.io/reports/issues/3196.html.
What changed
runEventLoopWorkSync.There are no wire, protocol, migration, schema, CLI, configuration, authentication, authorization, permission, packaging, or release changes.
How you verified
origin/mainin two clean checkouts because no intermediate event-loop progress was observable; it passes after the fix.pnpm exec turbo run test --filter=@bb/server -- test/services/periodic-sweeps.test.ts test/services/completed-output-yield.test.ts test/system/event-loop-stall-monitor.test.ts— 18 tests passed.pnpm exec turbo run test --filter=@bb/db— 448 tests passed.pnpm exec turbo run typecheck --filter=@bb/db --filter=@bb/server— 6 tasks passed.git diff --checkpassed.Fixes #3196