Keep root composer project selection tab-scoped - #3191
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The root composer project atom subscribed to cross-tab localStorage events. A tab with a settled but stale sidebar project list normalized a project selected elsewhere to the personal project, then persisted that fallback back to every tab. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3190.html.
What changed
The root composer project selection now uses the existing tab-scoped storage adapter. Each tab retains its own active project through session storage, new tabs can still seed from the most recent local value, and live storage events no longer move another tab's composer. The regression test simulates the cross-tab event and asserts that the stale tab never writes the personal fallback. There are no wire, CLI, guide, dependency, schema, or stored-data changes.
How you verified
pnpm exec turbo run test --filter=@bb/app: 480 files passed; 3,926 tests passed and 3 skipped.pnpm exec turbo run typecheck --filter=@bb/app: passed.pnpm exec turbo run lint --filter=@bb/app: passed with 0 errors (184 existing warnings).git diff --check origin/main..HEAD: passed.Fixes #3190