Reuse non-git parent environments for child threads - #3176
Closed
bb-slop-cop[bot] wants to merge 1 commit into
Closed
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
Collaborator
|
Closing this implementation because the environment-provider rewrite replaced the infrastructure it targets. The non-Git parent/child environment selection problem in #3175 remains relevant and needs a fix against the current architecture. This closure does not mark the underlying issue as fixed. Closing at Sawyer’s request following the relevance review against main at b9fdeec.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Child-thread environment defaulting received only the parent thread record, so it could not distinguish a parent running directly in a non-git folder from one using a Git checkout. It therefore selected managed-worktree provisioning for every live parent. Separately, repository-directory basename validation accepted only ASCII letters and digits. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3175.html.
What changed
The server now supplies the parent's persisted environment to the internal default policy and reuses it only when the thread, environment, project, and host match and the workspace is unmanaged and non-git. Git parents and mismatched environments retain the managed-worktree default. Repository-directory validation now accepts Unicode letters, numbers, and combining marks while retaining the existing traversal, whitespace, and leading-dash protections. There are no wire, CLI, SDK, schema, dependency, migration, or generated-file changes.
How you verified
origin/main, it failed 3/3: the service created a different environment, policy selected managed-worktree, and the Unicode basename was rejected.pnpm exec turbo run typecheck --filter=@bb/serverpassed.git diff --checkpassed.git diff --numstat origin/mainreports 194 total changed text lines across 4 files and no binary changes.Fixes #3175