Distinguish pinned workflow status from message previews - #3164
Closed
bb-slop-cop[bot] wants to merge 1 commit into
Closed
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
3 tasks
Collaborator
|
Closing because adding an Active label distinguishes the two workflow cards but does not remove the duplication reported in #3162. A replacement should address the intended workflow-card behavior. This closure does not mark the underlying issue as fixed. Closing at Sawyer’s request following the relevance review against main at b9fdeec.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The workflows plugin independently renders a message directive and an active-run composer banner for the same running workflow. Both surfaces used the same primary label and status content, so adjacent instances had no persistent identity distinguishing the pinned live status from the historical message preview. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3162.html.
What changed
The composer-only workflow card now shows a compact
Activeprefix and uses anActive workflow: <name>accessible label. The message preview keeps its existingWorkflow: <name>identity. A component regression test renders both registrations for one run and verifies the distinction. There are no wire, protocol, CLI, guide, dependency, or data changes.How you verified
Active.pnpm exec turbo run test typecheck --filter=bb-plugin-workflowspassed: 223 tests and the package typecheck.Workflow: Review the releasepreview and one visibleACTIVEcomposer card with theActive workflow: Review the releaseaccessible label.pnpm exec oxfmt --check plugins/workflows/src/app.tsx plugins/workflows/src/app.test.tsxandgit diff --checkpassed.browserCLI family on the trusted base; the affected workflows UI recipe was verified through the focused test and production-component browser harness without starting a workflow.Fixes #3162