Repository navigation
fix(parser): alternatives inside one species keep the species - #227
Merged
Merged
Conversation
"Bubo virginianus pallescens / Bubo virginianus pinorum intergrade" and "Tachybaptus ruficollis tricolor/vulcanorum" were anchored on the genus, though all their alternatives lie in one species. A name with a word below its species is now anchored on that species, unless another alternative names a different species or a qualifier in front of the species doubts it. The rest of the name is the phrase, the rank stays UNRANKED and the state partial. A separate authorship still joins the phrase, as it belongs to no one of the alternatives for sure. It would have been lost: the phrase took an authorship only without a species epithet, so the flag that asks for it now decides on its own. Refs #212, #225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatives that all lie in one species are now anchored on that species instead of the genus. #212 hoped for this for the intergrades.
Bubo virginianus pallescens / Bubo virginianus pinorum intergradeBubo virginianuspallescens / Bubo virginianus pinorum intergradeTachybaptus ruficollis tricolor/vulcanorumTachybaptus ruficollistricolor/vulcanorumMemphis philumena aff. xenica/promenaeaMemphis philumenaaff. xenica/promenaeaBubo virginianus pallescens / Bubo scandiacusBubo(unchanged)virginianus pallescens / Bubo scandiacusAgabus cf. lutosus griseus/griseipennisAgabus(unchanged)cf. lutosus griseus/griseipennisThe name stays
INFORMAL,UNRANKEDand partial, and its anchor has rankSPECIES. The species is set inspecificEpithet, sogenus + specificEpithet + phrasestill gives the input back.The rule is wider than the intergrades. A lone epithet after a trinomial counts too, so
Tachybaptus ruficollis tricolor/vulcanorumchanges from the expectation in #225. OtherwiseBubo virginianus pallescens/pinorumand its written-out form would get different anchors.A separate authorship joins the phrase. It may belong to either alternative, so it does not go on the species:
Bubo virginianus pallescens/pinorum+Stone, 1897gives phrasepallescens/pinorum Stone, 1897. The phrase only accepted an authorship when there was no species epithet, which would have lost it, sophrase_takes_authorshipnow decides on its own.Not changed: a binomial followed by its own infraspecific name (
Rosa gallica|Rosa gallica var. officinalis,Ganoderma lucidum/Ganoderma lucidum fusant) stays on the genus. The phrase would have to start with the separator.Impact
Compared with #226 on every name containing a slash, a pipe or
or, the only names this rule can reach: