Repository navigation
fix(build): remove obfuscated-looking code rejected by the Chrome Web Store - #575
Merged
Merged
Conversation
… Store The 1.1.8 submission was rejected for obfuscated code: the flagged snippet is core-js (IE polyfills) bundled inside vuedraggable, which is unmaintained. Replace it with vue-draggable-plus (maintained, ESM, no core-js) for the rules drag and drop, and stop minifying the build so reviewers get readable code.
📦 Extension Build Ready!Version: 📥 Download Extension (tabee.zip)Installation
Status
🤖 Auto-generated by GitHub Actions |
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 1.1.8 submission was rejected by the Chrome Web Store for obfuscated code ("Red Titanium", code readability requirements). Flagged snippet, in
assets/options.html-*.js:This is core-js (Internet Explorer polyfills), shipped pre-bundled inside
vuedraggable's dist files and minified by our build.vuedraggable4.1.0 is unmaintained (last published 2023). We use it in one place: drag and drop to reorder rules.Fix
vuedraggablewithvue-draggable-plus0.6.1: maintained (2026), ESM, same SortableJS engine, no core-js. InTableRules.vuethe rows are a plainv-forinstead of the#itemslot;onDragEndis unchanged.build.minify: false): minification is allowed by the store, but this rejection shows reviewers may read minified code as obfuscated. The package now ships readable code with real names. JS goes from 333 KB to 629 KB, but the zip is smaller than 1.1.8 (297 KB vs 323 KB) since core-js is gone.Checks
IE_PROTO/core-jsleft indist/. Scan foreval,new Function,document.write,atob: none (oneString.fromCharCodein FileSaver's export, adding a BOM: readable and legitimate).vue-tscand build pass;npm audit: 0 vulnerabilities.