Repository navigation
fix(shortcuts): merge windows with Option+Shift+W on Mac instead of Cmd+Shift+W - #573
Merged
Merged
Conversation
On macOS the default Command+Shift+W is Chrome's own 'close window' shortcut, so users merged all their windows by accident (reported in a Chrome Web Store review). Merging stays available from the context menu, and users can assign a key in chrome://extensions/shortcuts.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Keep a default shortcut, but the same one as on Windows/Linux: Option+Shift+W does not conflict with Chrome or macOS shortcuts, unlike Command+Shift+W (Chrome's 'close window').
sebastienfontaine
changed the title
📦 Extension Build Ready!Version: 📥 Download Extension (tabee.zip)Installation
Status
🤖 Auto-generated by GitHub Actions |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Chrome Web Store review (2★) reports that the Windows Merger "overwrites a common, pre-existing keyboard shortcut", and that triggering it by accident collapses all windows into one, with no undo.
On macOS our default was Command+Shift+W, which is Chrome's own close window shortcut. Users closing a window merged all their windows instead.
Fix
merge-windowsnow uses Alt+Shift+W on every platform, i.e. Option+Shift+W on Mac. It conflicts with no Chrome or macOS shortcut (Chrome's close window is Cmd+Shift+W on Mac, Ctrl+Shift+W elsewhere). Windows/Linux are unchanged.chrome://extensions/shortcutsto change or remove it.Note on existing installs
Fresh installs get Option+Shift+W. I'm not sure whether Chrome replaces the previously suggested key on update; existing Mac users may keep Cmd+Shift+W until they change it in
chrome://extensions/shortcuts.Tests
merge-windowskey is Chrome's close-window shortcut, and all platforms share Alt+Shift+W. Both fail with the previous manifest.chrome.commands.getAll()):merge-windows: "⌥⇧W",spot-search: "⇧⌘E".vue-tscand build pass.