fix(benchmarks): use nullMarkers in csvOptions and add missing request counter schema fields - #1062
Merged
zhixiangli merged 2 commits intoSep 18, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the data types of several fields (batch_size, max_gap, num_ranges, and total_bytes) from INTEGER to STRING in the benchmarks schema. The reviewer suggests keeping these fields as INTEGER and instead configuring csvOptions to treat empty strings as NULL, which preserves schema quality and proper numeric types for querying.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 16 16
Lines 3749 3749
=======================================
Hits 3382 3382
Misses 367 367 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yuxin00j
marked this pull request as draft
September 14, 2026 05:14
yuxin00j
marked this pull request as ready for review
September 14, 2026 05:34
zhixiangli
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"nullMarker": "N/A"to"nullMarkers": ["N/A", ""]incloudbuild/benchmarks/benchmarks_schema.json(matchingmacrobenchmarks_schema.jsonandsubsystembenchmarks_schema.json) so BigQuery treats empty strings from missing columns in historical CSVs asNULL, preserving numeric types (INTEGER/FLOAT).concurrency,requests_total,requests_per_op,requests_download,requests_object_get,requests_list,requests_other).Problem
"sourceColumnMatch": "NAME", missing columns evaluate to empty strings (""). With"nullMarker": "N/A", BigQuery did not treat""asNULL, failing ingestion when parsing""intoINTEGERcolumns (batch_size,max_gap,num_ranges,total_bytes). Using"nullMarkers": ["N/A", ""]resolves this while preservingINTEGERtypes.concurrency,requests_total,requests_per_op,requests_download,requests_object_get,requests_list,requests_other) in CSV headers, which caused BigQuery ingestion to fail withUnmatched source column foundwhen scanning newer CSVs.