feat(sandbox): surface agent transcript errors - #239
Merged
eshulman2 merged 2 commits intoAug 23, 2026
Conversation
Signed-off-by: Dhruv Maniya <dhruvmaniya1998@gmail.com>
Signed-off-by: Dhruv Maniya <dhruvmaniya1998@gmail.com>
eshulman2
force-pushed
the
agent/surface-transcript-errors
branch
from
August 23, 2026 09:47
d23b3dc to
9a9ba79
Compare
eshulman2
approved these changes
Aug 23, 2026
eshulman2
left a comment
Collaborator
There was a problem hiding this comment.
Rebased onto current main and reviewed the conflict resolution and resulting diff. The container-driver refactor is preserved, transcript extraction is wired to ExecResult, and focused tests plus Ruff checks pass. No blocking findings.
eshulman2
marked this pull request as ready for review
August 23, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
.forge/history/<task>.jsonartifactnon-zero container exit
error level
Why
Container stderr often contains only startup noise. Forge already persists the
Deep Agents conversation, but the host runner did not consult it and omitted
the stop/status metadata needed to identify failures. The new parser uses that
existing task-scoped JSON artifact, bounds logged excerpts to 1,000 characters,
and leaves startup unaffected when history is missing or malformed.
Checks
uv run pytest -q tests/unit/sandbox/test_transcript_errors.py tests/unit/sandbox/test_runner_review_polling.py(31 passed)uv run ruff check src/forge/sandbox/runner.py containers/entrypoint.py tests/unit/sandbox/test_transcript_errors.pygit diff --checkFixes #79