Repository navigation
One parquet engine - #2744
Merged
Merged
One parquet engine#2744
Conversation
…h flow_php - crate flow-parquet-engine, linked into both extensions - flow_php on arrow-* 60 - split, PIE archive and Nix follow the links - CI runs the Parquet adapter suites per extension lane - arrow-ext release build stripped
…e memory limit - FlowPhpParquetEngine, the adapter default with flow_php - no Arrow C hop between the extensions - ETL without flow_php reads and writes on the PHP engine - arrow-ext without the batch classes, FLOW_ARROW_ABI 3 - redundant variable warnings in ExternalSort
…on Linux - mmap threshold fixed at 128 KiB at startup, the environment still wins - phpt 001 no longer depends on the extension load order
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2744 +/- ##
============================================
- Coverage 91.08% 91.07% -0.01%
- Complexity 32248 32255 +7
============================================
Files 2238 2238
Lines 93175 93192 +17
============================================
+ Hits 84865 84879 +14
- Misses 8310 8313 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/flow-php-ext- Parquet engineFlowPhpParquetEngine, counted by the memory limit of a runflow-php/flow-php-ext- shared crateflow-parquet-enginewith the Parquet Rust codeflow-php/etl-adapter-parquet- CI runs the adapter suites with each extension and with bothFixed
flow-php/flow-php-ext- freed large buffers return to the system on Linuxflow-php/etl-adapter-parquet- a worker loads the extension of its engineflow-php/etl- redundant variable warnings inExternalSortChanged
flow-php/etl-adapter-parquet- default engine isFlowPhpParquetEnginewithflow_php, elsePhpParquetEngineflow-php/flow-php-ext- reads and writes Parquet withoutarrowflow-php/flow-php-ext-arrow-*crates 59 to 60flow-php/arrow-ext- Parquet code moved to the shared crateflow-php/arrow-ext-FLOW_ARROW_ABI2 to 3flow-php/arrow-ext- release build is strippedRemoved
flow-php/arrow-ext-RustBatchReader,RustParquetBatch,RustArrowSchemaflow-php/arrow-ext-RustParquetFileWriter::writeArrowBatch()flow-php/flow-php-ext-RustColumnsBatchand the crateflow-arrow-cDeprecated
Security