Skip to content

review: allow multiple options even for ignore action - #656

Open
dongsupark wants to merge 2 commits into
mainfrom
dongsu/ignore-multiple-actions
Open

dongsupark wants to merge 2 commits into
mainfrom
dongsu/ignore-multiple-actions

Conversation

@dongsupark

Copy link
Copy Markdown
Member

Allow users to take multiple actions even in case of ignore action. Create, ignore, manual.

See also #602 (comment).

Testing done

Manual tests passed

Allow users to take multiple actions even in case of ignore action.
Create, ignore, manual.

See also #602 (comment).

Signed-off-by: Dongsu Park <dongsu@dpark.io>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Summary aggregation treats the first candidate as the recommendation, causing ignore-only decisions to inflate create counts in both part and whole-batch summaries.

1 open issue
What changed in this PR

This PR expands the human-gated review menu for ignored discovery records, allowing maintainers to override an ignore recommendation while still choosing at most one action per group.

Changes:

  • Route ignored records through the existing manual-review menu.
  • Update tests to expect create, ignore, and manual options with distinct action IDs.
  • Preserve the single acknowledgment option for kernel routing.
File Description
tests/​test_review.py Verify expanded ignore options and shared group identity.
src/​security_triage/​review.py Reuse the manual-review menu for ignore decisions.

Review effort: Balanced

Comment thread src/security_triage/review.py Resolved
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes enabling maintainers to override ignore recommendations.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@dongsupark
dongsupark marked this pull request as ready for review November 19, 2026 14:22
@dongsupark
dongsupark requested review from a team and danielszot as code owners November 19, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants