Repository navigation
Conversation
The Create or Recover Wallet dialog showed about 230 words of instructions and every input for both paths at once, greyed out when they didn't apply, with the recovery phrase typed into one line. Split it into three pages: - Welcome: two choices, create a new wallet or restore one. - Create: what the recovery phrase is and how to keep it safe, with the 12-word option and the extra passphrase under a collapsed "Advanced options". - Restore: a numbered 12/24-word grid. Each number has its own column, so words never run into it. Pasting the phrase into a box fills it and the boxes after it, and typing a space moves to the next box. Words autocomplete from the BIP39 list, and words not on it are flagged. The extra passphrase is one field with show/hide. The wallet creation date only shows when blocks are already on disk: the restore rescan only covers blocks already on disk, so on a fresh install the date does nothing. Its minimum reads "Not sure" and leaves -wcdate unset, which scans from where recovery phrases began, as the old default did. Dates after today are no longer accepted. Checks now run in the dialog before it closes, so askRecover sets the startup args once, from accepted input only. Passphrase fields stop at 256 characters (wallet creation rejects longer ones). The RAP address count is gone; RAP addresses are being retired. -defaultrapaddressnumber still works from the command line or firo.conf. Tests: update emptyRecoverySeed and recoveryRetryUsesFinalInput for the new widgets; the retry test pastes the phrase into the first box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeAnt-AI DescriptionRedesign wallet setup with guided creation and recovery What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd5ba84cf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CodeAnt Nitpicks2 code suggestions1.
|
CodeAnt PR Risk: High Risk
Assessed commit: |
Review follow-ups for the wallet setup dialog: - A paste with more words than the boxes left is refused instead of silently dropping the extra words. Words that reach past box 12 switch the grid to 24 boxes rather than landing in hidden ones. - Restoring in 12-word mode is refused while boxes 13 to 24 still hold words, so a 24-word phrase entered under the wrong length can't restore from its first 12 words. - Passphrase length is checked in UTF-8 bytes against the 256-byte limit CreateWalletFromFile enforces. The 256-character field limit it replaces let multibyte passphrases through to fail at startup. Tests: extend recoveryRetryUsesFinalInput to cover all three. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Replaces the single long "Create or Recover Wallet" form (about 230 words of instructions, with every input for both paths shown at once) with a three-page setup dialog.
-wcdateunset, which starts the scan at the same block as the old default. Dates after today aren't accepted.askRecoversets the startup args once, from accepted input only. Passphrases over the wallet's 256-byte limit are refused before the dialog closes, and so are pastes that don't fit the boxes left and words hidden by the 12-word choice.-defaultrapaddressnumberstill works from the command line orfiro.conf.Stacked on #2015
The base is #2015's branch, so this diff is only the redesign commit. Merge #2015 first.
Testing
test_firo-qton Linux (WSL, depends toolchain) and ran it on the minimal platform.WalletUiTests::emptyRecoverySeedandWalletUiTests::recoveryRetryUsesFinalInputpass. Both were updated for the new widgets, and the retry test now pastes the phrase into the first box.WalletUiTests::themeTintColorsfails the same way on Wallet: Stop restore args leaking past their use #2015's head.🤖 Generated with Claude Code