profiler-cli: accept several marker handles and ranges in marker info - #6277
Open
fqueze wants to merge 1 commit into
Open
profiler-cli: accept several marker handles and ranges in marker info#6277fqueze wants to merge 1 commit into
fqueze wants to merge 1 commit into
Conversation
Inspecting a sequence of markers meant one invocation per handle. `marker info` now takes a list of handles, comma-separated handles, and m-1..m-3 ranges in any combination, returning a marker-info-multi result for two or more markers. Any spelling meaning exactly one marker keeps the previous text and JSON output byte for byte. An unresolvable handle is reported in place with the rest still shown and a non-zero exit; a malformed spec, reversed range, or range wider than 256 handles fails before any lookup. Ranges expand numerically and handle numbering continues across listings, so a range overrunning its listing resolves into unrelated markers. When one lands in more than one thread the CLI warns and exits non-zero.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6277 +/- ##
==========================================
+ Coverage 83.79% 83.81% +0.02%
==========================================
Files 350 350
Lines 37583 37637 +54
Branches 10459 10470 +11
==========================================
+ Hits 31492 31546 +54
Misses 5664 5664
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Inspecting a sequence of markers meant one invocation per handle.
marker infonow takes a list of handles, comma-separated handles, and m-1..m-3 ranges in any combination, returning a marker-info-multi result for two or more markers. Any spelling meaning exactly one marker keeps the previous text and JSON output byte for byte.An unresolvable handle is reported in place with the rest still shown and a non-zero exit; a malformed spec, reversed range, or range wider than 256 handles fails before any lookup.
Ranges expand numerically and handle numbering continues across listings, so a range overrunning its listing resolves into unrelated markers. When one lands in more than one thread the CLI warns and exits non-zero.