fix(require): preserve @INC hook generator state - #1324
Merged
Conversation
Decode the generator hook return form as (generator, state), rather than only reading the state slot used by filehandle filters. Pass state through the generator's @_ by alias so repeated calls do not leak state references. Add JVM and interpreter regression coverage and document the compatibility fix. Generated with [Codex](https://openai.com/codex/) Co-authored-by: Codex <codex@openai.com>
fglock
force-pushed
the
fix/inc-hook-generator-state
branch
from
September 9, 2026 17:06
9b2b575 to
e39be21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@INChook source generatorValidation
makemake check-linkstimeout 60 perl src/test/resources/unit/inc_hook_generator_state.ttimeout 90 ./jperl src/test/resources/unit/inc_hook_generator_state.ttimeout 90 ./jperl --interpreter src/test/resources/unit/inc_hook_generator_state.t