fix(docs): correct dead references in generators/rust and generators/cli CLAUDE.md - #17610
Open
wallidsaydi-creator wants to merge 1 commit into
Open
Conversation
…E.md - rust: point configuration schema to the real SdkCustomConfig.ts / ModelCustomConfig.ts (custom-config/ paths never existed on main) - cli: replace deleted tests/cli_integration.rs + openapi_fixture_wire.rs with the current sdk/.sdk-ignore.json ignore mechanism - cli: replace deleted sdk/docs/DESIGN.md with the live sdk/docs/customize.md and drop the stale 'planned' hedge Fixes fern-api#17581
wallidsaydi-creator
requested a review
from iamnamananand996
as a code owner
September 1, 2026 19:15
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![nitpickybot[bot]](https://avatars.githubusercontent.com/in/2901896?s=60&v=4){kind=small}
There was a problem hiding this comment.
Docs-only PR fixing three stale file references in agent-guidance CLAUDE.md files. Paths and wording look consistent with the described current tree; nothing functional at risk. No blocking issues.
To request another review, comment /ai-review on this pull request.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
wallidsaydi-creator
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17581
Three dead references in agent-guidance files, re-verified against
main@ 8bfa8e2 before filing this PR:1.
generators/rust/CLAUDE.md— phantom schema pathsThe line pointed to
generators/rust/codegen/src/custom-config/RustSdkCustomConfigSchema.tsandRustModelCustomConfigSchema.ts. Neither path has ever existed on main (custom-config/holdsBaseRustConfigSchema.ts/RustDependencySpecSchema.ts/CustomReadmeSectionSchema.ts— no Rust* files). The real schemas live in:generators/rust/sdk/src/SdkCustomConfig.ts→SdkCustomConfigSchemagenerators/rust/model/src/ModelCustomConfig.ts→ModelCustomConfigSchemaBoth extend
BaseRustCustomConfigSchemafrom@fern-api/rust-codegen.2.
generators/cli/CLAUDE.md— deleted test filesThe doc cited
tests/cli_integration.rsandtests/openapi_fixture_wire.rs(deleted in #16056, ~4.4k lines removed during the binding/auth migration; neither file exists anywhere in the current tree) and attributed the ignore list toSDK_IGNOREinbuild.mjs. Perbuild.mjs's own header comment, the dev-only globs now live insdk/.sdk-ignore.jsonas the canonical home, merged intoSDK_IGNOREat build time. Updated to describe the current mechanism.3.
generators/cli/CLAUDE.md— deleted DESIGN.mdThe
customize/guidance linkedsdk/docs/DESIGN.md(deleted in #16264) and hedged it as "planned". The successorsdk/docs/customize.mdexists and documents customization as shipped behavior, so the dead link is replaced and the stale hedge dropped.All three are the exact class of drift that misdirects coding agents working in these directories — an agent following the rust line today searches for files that never existed.
Happy to adjust wording if you'd phrase the ignore-list description differently.