Repository navigation
fix(ci): resolve cargo deny advisories and eliminate mutation test failures - #166
Merged
Merged
Conversation
… regressions - Update crypto-bigint (0.7.10) and ctutils (0.4.6) resolving RUSTSEC-2026-0387 and RUSTSEC-2026-0385 - Eliminate obfuscate_into timeout by refactoring to idiomatic chunks_mut iterator - Use raw_wire_len.max(max_budget) in round_to_bucket, removing equivalent comparison mutant - Replace manual length check with .get() in Handshake::read_message and add truncated message tests - Add test coverage for Transport set_symbol_size, symbol_size, observe_ingress, and fec_recovered_count - Add symmetric canonical flow key assertion for FlowKey::canonical - Add active_probe_id state tracking test for PlpmtuController - Add k=1 repair symbol index test and recovered_count assertions in FecReassembler - Correct last shard length in oversized_object_guard_rejects_before_touching_shards - Add exact inclusive deadline boundary test (now_ms == expires_at_ms) in FecReassembler - Refactor received shard padding in FecReassembler::push and document proven equivalent mutants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses all active CI failures on
mainfollowing PR #164, specifically:cargo denyAdvisories:crypto-bigintto0.7.10andctutilsto0.4.6, resolvingRUSTSEC-2026-0387(timing variability in arithmetic) andRUSTSEC-2026-0385(non-constant-time mask generation).cargo deny check(advisories ok, bans ok, licenses ok, sources ok) pass cleanly.Mutation Testing Rigor (
cargo-mutants):crates/yip-obf:obfuscate_intoby refactoring the while loop to a safe, idiomaticchunks_mut(8)slice iterator.if raw_wire_len < max_budgetcomparison inround_to_bucketwithraw_wire_len.max(max_budget), removing the uncatchable equivalent mutant.skip_calls = ["reserve"], preventing synthetic mutations on non-binding capacity allocation hints.crates/yip-crypto:Handshake::read_messagewith.get(..PQ_CIPHERTEXT_LEN)and adds test coverage for truncated handshake messages (pq_handshake_read_message_rejects_truncated_message).pq_encapsulatewhere manualByteDecode_12validation is duplicate withml-kem-512's own internalByteDecode_12checks.crates/yip-transport:crates/yip-transport/src/lib.rsforset_symbol_size,symbol_size,observe_ingress, andfec_recovered_count.crates/yip-transport/src/classify.rsverifyingFlowKey::canonical.PlpmtuController::active_probe_idacross probing and converged states incrates/yip-transport/src/plpmtu.rs.recovered_countassertions incrates/yip-transport/src/fec.rs.oversized_object_guard_rejects_before_touching_shardsso that object size bounds checking is isolated and verified.now_ms == expires_at_ms) for both decode and FIFO queue sweep inFecReassembler.FecReassembler::pushand documents proven equivalentVec::resizeno-op mutation in.cargo/mutants.toml.Workspace-Wide Verification:
cargo test --workspace) with 100% pass rate.cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo shear, graph checks, and wire-format diagram checks all pass.